Keith Wall

Couple of comments left, but looks reasonable to me.

Let me state my use-case, just to make sure we are on that same page. As a user of Kroxylicious, I want to able to see if a system slow...

If we had a https://docs.asciidoctor.org/asciidoctorj/latest/extensions/block-processor/ that was capable of validating the block's content, we could then pull this into our `asciidoctor-maven-plugin`. I'm surprised that something like that doesn't exist already....

Thanks for raising the issue. nit: I think the service ports need to match the ports known by the proxy. We currently have no mechanism to have the proxy open...

### Proxy On the Proxy side, my idea to give the `portIdentifiesNode` a new capability. ```yaml portIdentifiesNode: nodePortMapping: 1: 9082 2: 9083 10: 9084 etc. ``` This puts the administrator...

> Another idea could be to manifest port-per-broker ingresses as an entirely separate proxy config/deployment so that the ingress Services only targets the pods of their Virtual Cluster. I think...

I don't remember clearly the reason why that is like that (I mean, why ApiVersion response sent prior to the upstream connection). @tombentley could you explain?

To my mind, the response needs to be `min(max api-version supported by broker, max api-versions supported by kroxy)`.

I'm not against the change, but if you need to enable logging to work out why a unit test is failing, that's often a code smell. The code under test...

What's actually meant here? 1. Are we thinking about how the use of the proxy plays with Kafka's [rack awareness features ](https://cwiki.apache.org/confluence/display/KAFKA/KIP-881%3A+Rack-aware+Partition+Assignment+for+Kafka+Consumers)? 2. Or are we thinking about ensuring the...