Keith Wall comments

Results 309 comments of


                                            Keith Wall

Could we code gen the multi-tenant filter?

> I think I'm missing how your generated filter would handle this apiVersion case, would it be aware from the json schema which fields are relevant at each apiVersion? Yes,...

Could we code gen the multi-tenant filter?

> I am un-convinced by the need for code generation here especially at this stage of development. I'm certain not seeing it as a now. I just wanted to put...

JsonSchemaBytebufValidator ignores the length parameter

@robobario low priority, but I'd value your thoughts on this.

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

This test case highlights a couple of shortcomings in the current implementation. * If the producer is using `apicurio.registry.headers.enabled` false, the filter **fails** as the JSON parse chokes on the...

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

@robobario would you mind giving this a quick review? I'm more interested in feedback on the idea - WDYT?

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

> A question: is it totally invalid to compare the message to schema X even though the messages are being sent with schema X+1 if it's still compatible with schema...

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

+ @carlesarnal wondering if you've got any thoughts about this PR?

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

> > However, I think as it stands now it is good enough to be considered an incubating feature. Hopefully user feedback will help guide us as what's most important....

Extend JsonSchemaValidator to validate the schema id used by the producer matches the schema id configured at the proxy.

My intent is to include in 0.7.0.

drop-release does not drop the prepare-v0.9.0-release-docs-yyyy-mm-dd release branch

So i'd suggest we refactor so that this project emits a docs artefacts, then we use something like https://github.com/marketplace/actions/repository-dispatch to trigger a workflow in kroxylicious.github.io to merge the docs. This...