jzmaddock

Results 150 comments of jzmaddock

Test case corrected for C++20 in develop.

Can you check the revised test case on BSD?

The tests under /all/ are useful sometimes, but need to be taken with a pinch of salt also. I would: cd libs/config/test ../../../b2 config_test Then make any changes you might...

Not unless someone volunteers to help us out - it looks to me like testing on CI would be problematic?

I'm quite certain that I'm not qualified to comment - anyone else?

What's the motivation for adding this to Boost.Config rather than the specific library that needs it - or is there a need across multiple libraries?

My inclination is to not merge this at this time - the rational is: * It's completely compiler specific (not necessarily a show stopper). * It's not required by multiple...

The problem I have is that this PR breaks the original purpose of those workarounds. Try this: https://github.com/boostorg/config/commit/46e0a134966bebb5496a2fd8d26a101e4b94ca95

That's nasty, but the fix looks almost as bad.... not sure what to do about this one.

Sorry for the delay in getting around to this! This is a weird one, and I'm not completely convinced msvc is at fault yet. If I change the == operator...