config icon indicating copy to clipboard operation
config copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Do not inject `typeinfo` into `std` namespace

Open Kojoley opened this issue 5 years ago • 4 comments

BOOST_NO_STD_TYPEINFO should be used to detect if there is no typeinfo in std namespace, or Boost.Core/Boost.TypeInfo wrappers for a portable solution.

Closes #306.

Kojoley avatar Dec 02 '19 18:12 Kojoley

@Kojoley I think you need to resolve the merge conflicts for this to ever have a hope of being merged.

jeremy-murphy avatar Jul 24 '20 05:07 jeremy-murphy

The change it conflicts with (035c096da942a3fa7f75180ae8b2f2732db0a9f4) is just wrong and should be reverted, then this will land cleanly.

Kojoley avatar Jul 24 '20 14:07 Kojoley

The problem I have is that this PR breaks the original purpose of those workarounds.

Try this: https://github.com/boostorg/config/commit/46e0a134966bebb5496a2fd8d26a101e4b94ca95

jzmaddock avatar Jul 25 '20 18:07 jzmaddock

What is the original purpose of those workarounds? To slow compilation for everyone because of Boost.LexicalCast? I fixed Boost.LexicalCast and it is not need the workaround in Boost.Config.

Kojoley avatar Jul 25 '20 18:07 Kojoley