Justin Brooks

Results 28 comments of Justin Brooks

> It is up to this plugin to also drop the support or to implement it directly. Dropping support in parity with the ktlint version seems reasonable. Especially if the...

I have a few questions here @shyiko. 1. Could you elaborate a little on why these rules might not play well with Kotlin Native? 1. Is the current direction to...

Results --- The benchmarks ran on an emulator (which might be less than ideal, but I don't have a rooted device such that microbenchmark can lock cpu freq) on a...

Here are results on a non-root, charging Pixel 3 (Android-12). The discrepancy between Jackson on a real device v emulator is interesting. The rest of the benchmarks didn't seem to...

Perhaps a new `--res-dir ` CLI option is in order. It would likely be required from conversion from VD to SVG, required if a resource is referenced in a vector...

It turns out that gradients are often represented in separate files and referenced using the resource system for vector drawables, which makes supporting them in the IR tricky.

I'm assuming the local has a different UAST type than the parameter name or that maybe somehow PSI resolution might help do that tracing. I agree it isn't a huge...

I wonder if the path forward involves leveraging `DataFlowAnalyzer` to track uses of modifiers. It's not much, but this detects some of the offending errors: https://github.com/slackhq/compose-lints/compare/main...jzbrooks:compose-lints:name-shadowing If some of the...

https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/VectorPathDetector.java;l=90

This seems reasonable given the arbitrary length choice and that it was made a while ago. https://issuetracker.google.com/issues/37136968#comment6