jyn
jyn
If I try `transitive-excludes` instead of `final-excludes`, I get `info: no changes detected`
> I think this is a bug (not specifying a branch should mean "include all branches") but hopefully this workaround will work for you. Thanks! With `traversal-excludes` that worked, but...
> Yeah, I think that would be a pretty good addition! This is honestly the first time excluding just a single feature (rather than an entire package) has come up...
Awesome! I have ~2 hours today to put into it, I'll take a stab and see what progress I can make :)
> We probably want to expose this via an optional features key in the excludes config. For example: > ```toml > [traversal-excludes] > workspace-members = [ > "my-crate", > {...
@sunshowers I'm sure there's a simple way to do this, but is there a way to tell serde "deserialize this struct, then another struct" without having to manually implement Visitor?...
actually I think this is just `serde(flatten)` - sorry for the ping
> This needs to be updated to handle excluding individual features as well. You're right, this is trickier :grin: I've plumbed down the individual features to `CargoSetBuildState` (it's very hacky...
> Feel free to put up whatever you have, I'm happy to finish it up in the next week or so I am not sure you want it as-is, it's...
Oh, also I think the commented-out code around `PackageSetSummaryWithFeatures::to_package_set_registry` was a bad idea, since it requires making lots of things from `guppy` public - I was planning to delete that...