James Cor

Results 60 comments of James Cor

This PR fixes the queries mentioned in this issue: https://github.com/dolthub/go-mysql-server/pull/2294 However, the fix is more of a point fix and does not fully address the varierty of type comparisons used...

That's a good idea. We should also add tests for multiple zeros, negative values (specificically -0.0), and scientific notation ``` 123.0...0 -0.0...0 123e3 -123.4e-2 ```

Hey @tim-oh-thee, Just wanted to make sure we are on the same page. You want support for the other `where_conditions` in `DECALRE ... HANDLER ...`: https://dev.mysql.com/doc/refman/8.0/en/declare-handler.html Not support for the...

Hey @vmg, GMS behavior here has changed. We currently always return `DOUBLE` regardless of the input types (this might also be the case for `COUNT`). We can start fixing this...

We've added a way to deal with database collation changes, describe here: https://github.com/dolthub/dolt/issues/7815#issuecomment-2105274869

Here's a summary of MySQL Server vs Status variables: https://dev.mysql.com/doc/refman/8.0/en/server-option-variable-reference.html (it seems like all Status variables start with a capital letter)

fixed in: https://github.com/dolthub/go-mysql-server/pull/2576

Hey @awarycha, Just merged a fix for this to dolt main. I had missed this particular case when adding this change. We can cut a release for you later today...

Fix for this is merged to dolt main. `STAGED` should work the same way as `WORKING` when used in a filter clause in dolt_diff system tables. For `HEAD`, `HEAD~`, ...,...

This is specific to `dolt sql` shell and `dolt sql -q "..."`. I'm not sure why, but the function `processParsedQuery` from `dolt/go/cmd/dolt/commands/sql.go`, special cases `DDL` statements and returns `nil` for...