John Blum

icon company Codeprimate, LLC icon location Portland, OR icon location Former Staff Engineer, Spring (Data) Team @VMware

Results 74 comments of John Blum

Change default value for KeyspaceEventMessageListener on keyspace event notifications

@christophstrobl - I also stumbled upon and noticed this [configuration](https://github.com/spring-projects/spring-data-redis/blob/3.1.2/src/main/java/org/springframework/data/redis/repository/configuration/EnableRedisRepositories.java#L196) in SD (Redis) Repositories today (i.e. `Ex`).

Edit and cleanup up Javadoc

Re-opening for additional cleanup and editing.

Edit and cleanup up Javadoc

This Javadoc [reference](https://docs.spring.io/spring-data/redis/docs/current/api/org/springframework/data/redis/core/ListOperations.html#rightPushAll(K,java.util.Collection)) is a prime example of incomplete, broken documentation. The Javadoc for the `ListOperations.rightPushAll(key, ...)` method states: ```txt rightPushAll Append values to key. Parameters: key - must not...

Allow adding specific keyspace/keyevent topic(s) with `KeyspaceEventMessageListener`

You should have a look at Issue #2670 as well. Also see PR #2671. There are good (examples) cases for your argument in this issue, and I generally agree with...

Refine `JedisConnectionFactory`

> Did a first review pass. The majority of changes impose a different style, resulting in code that requires more effort to read (harder to read) and that isn't an...

Refine and clarify operations in the async cache implementation

> Did a first review pass. Thank you for the feedback. I reviewed each comment and cited my reasoning for the requested changes. I reworked this PR to be more...

`GenericJackson2JsonRedisSerializer` can't deserialize previously serialized `Stream.toList()`

I reproduced this problem in the following test case method that I am currently adding to the `GenericJackson2JsonRedisSerializerUnitTests` class in Spring Data Redis to debug and explore possible solutions. ```java...

Add `cursorId` to `ScanOptions`

You might want to post this "question" on StackOverflow ([here](https://stackoverflow.com/questions/tagged/spring-data-redis)) to the [Spring Data] Redis community at large. GitHub Issues for Spring Data Redis are for bugs, improvements and new...

Add `cursorId` to `ScanOptions`

I will need to think on this more... I was re-reading about the Redis `SCAN` command ([doc](https://redis.io/commands/scan/)) and came across a few more interesting tidbits. Search for: * "Number of...

Add `cursorId` to `ScanOptions`

PART 1 (of 2): After a more careful and thorough analysis, I have learned more about Redis's behavior as well as limitations (questionably, and arguably, a bug) in Spring Data...