spring-data-redis icon indicating copy to clipboard operation
spring-data-redis copied to clipboard
verified publisher icon spring-projects

Refine and clarify operations in the async cache implementation

Open jxblum opened this issue 2 years ago • 1 comments

See #2743

jxblum avatar Oct 17 '23 22:10 jxblum

Did a first review pass.

Thank you for the feedback. I reviewed each comment and cited my reasoning for the requested changes.

I reworked this PR to be more inline with our expectations.

Specifically, I:

  1. Added a more robust check to the detection of Reactive types and usage, not unlike Spring Boot (here).

  2. I reduced the number of private (helper) methods only slightly and reorganized them based on where they belong. Certain private methods remain because 1) they are reused 2) and/or are more descriptive (especially in the Reactive context).

  3. Please! Can we follow the Spring Framework Javadoc guidelines.

jxblum avatar Oct 18 '23 21:10 jxblum