Jarosław Wygoda
Jarosław Wygoda
I wrote some tests and docs. Should I deprecate stuff used for retrieving storages backends?
@felixxm Thanks for the review! I've deprecated `get_storage_class`. Both `DefaultStorage` and `ConfiguredStorage` use this method so we'll get a deprecation warning from there. Should I deprecate these classes separately with...
@felixxm `DefaultStorage` and `ConfiguredStorage` need to stay after all because `default_storage` and `staticfiles_storage` depend on settings and need to be lazy. I've deprecated `STATICFILES_STORAGE` and `DEFAULT_FILE_STORAGE`, wrote tests and docs....
@felixxm I've applied requested changes, it's ready for review.
@carltongibson Can we tackle the `storage` argument to `FileField` in a separate ticket? Which shortcut do you mean? Is it `settings.STORAGES["file_storage"]`? If so see https://github.com/django/django/pull/15610/files#diff-1d5b04b0d2298a5675c19aeca9f82d3b5c08870a515f9c5063b77294279365beR2654
Thanks a lot for the review, @rycee! I've added a test case.
No worries @carltongibson, hope you're feeling better now. I've updated the docs with an example usage of storages in `FileField`. I didn't add tests because it relies on the existing...
Is there anything else needed to get this merged? @carltongibson @felixxm
Hi @carltongibson, It's fixed now.
@bhavya-tech This pr is ready for review.