Jeffrey Reep

Results 70 comments of Jeffrey Reep

The $A_{\text{sum}}$ term appears to be a normalization factor of the integral of $\phi(y)$ (or $\psi(y)$ in the code). [See here.](https://github.com/wtbarnes/fiasco/issues/43#issuecomment-1945249591). Confirmation would be appreciated, though!

Thanks for the helpful response. I see that the coding guide does address most of my concerns.

Would this issue be more easily solved with function overloading? In C++, at least, the trivial solution would be to have three functions with different inputs. I haven't used it...

The ruff error failing is [FBT003](https://docs.astral.sh/ruff/rules/boolean-positional-value-in-call/), from this line `return category_list if particlewise else np.allclose(category_list, True)` which I think is complaining about the call to `np.allclose`. An alternative formulation, which...

This caused a lot of other tests to fail because `is_category` appears to be used pretty commonly in the decorators. I'm guessing to avoid breaking lots of other parts of...

Thanks @namurphy! I've ~~added the suggested `noqa`~~ replaced `np.allclose(category_list, True)` with `all(category_list)` and tried to update the decorator code to fix the issues. It looks like it's solved most of...

Sorry for the commits going back and forth. I'm trying to understand the issue with the static type checking. I've changed `ParticleList.is_category` to return either `bool` or `list[bool]` which is...

@namurphy, please review when you can. I finally managed to get the issues sorted.

Thinking a bit about this logic, but isn't this the difference between `np.allclose` and `np.isclose`? ``` >>> x = [True, False] >>> np.isclose(x, True) array([ True, False]) >>> np.allclose(x, True)...