John W. Peterson

Thanks, I tried the latest cppclean version and confirmed that the false positive is gone in the simple test code. However, when I tried the new cppclean on my real...

Ah, the issue is that the `using namespace` declaration gets included from a separate file in the real application. So the following two-file test exhibits the same spurious warning: namespace.h...

> I didn't think of this pattern with the using namespace in another file. You really have this pattern in a project ? Using namespace inside headers are already considered...

This issue was discussed a bit in #2565, apparently with regard to Intel 19 and 20 rather than Intel 18. From what I can tell (and based on [this comment](https://github.com/libMesh/libmesh/pull/2565#issuecomment-628872160),...

OK, thanks for this additional information. In #2565, [this comment](https://github.com/libMesh/libmesh/pull/2565#issuecomment-628272502), I believe it was determined that we can build with Intel-18 provided that libmesh is configured with `--disable-metaphysicl`. That being...

In the failing line of code above, `FEAbstract::_p_level` is an `unsigned int`, `fe_type.order` is of type `OrderWrapper`, which internally stores its value as `int` but provides implicit conversion-to-enum and conversion-to-int...

OK, I'm glad you were able to get it working, and I agree that it's unlikely that anything was broken by the change. I assume that you were working from...

I assume that `BoundingBox.h` is one of your app's files. ``` BoundingBox.h:19:34: error: ‘RealVectorValue’ does not name a type void update_from_triangle(const RealVectorValue& V1, const RealVectorValue& V2, const RealVectorValue& V3, const...

> shellsystem.h:85:2: error: ‘AutoPtr’ does not name a type > AutoPtr shellelement; All instances of `AutoPtr` in your old code should be replaced by `std::unique_ptr`. Generally, this is just a...

``` petsc_shell_solver.h:45:55: error: expected template-name before ‘