Jason Merrill issues

Results 20 issues of


                                            Jason Merrill

Beaker's pylibmc extension never relinquishes its thread connections

[pylibmc's documentation on ThreadMappedPool](http://sendapatch.se/projects/pylibmc/pooling.html#a-note-on-relinquishing) specifies > You must be sure to call ThreadMappedPool.relinquish() before exiting a thread that has used the pool, from that thread! Otherwise, some clients will never...

Cleanup: Document or remove use of the `unselectable` property

Mathquill currently makes use of the non-standard (and IE only) `unselectable` property. We should either provide additional documentation of why this is necessary, or stop using this property. Documentation of...

Parser design flaw: times cannot be used with parsers that can produce falsey values

Ref: https://github.com/mathquill/mathquill/pull/967#discussion_r851586269

Cleanup: use runtime assertions instead of type casts in eachNode and foldNodes

The `eachNode` and `foldNodes` functions defined in `tree.ts` assume that they will be able to follow an unbroken chain of defined sibling nodes from their left end to their right...

Type Cleanup: Represent that deleteOutOf may not exist

Ref: https://github.com/mathquill/mathquill/pull/967#discussion_r851583384

Cleanup: use ?. operator to simplify property checks

Examples: * https://github.com/mathquill/mathquill/pull/967#discussion_r851580859 * https://github.com/mathquill/mathquill/pull/947#discussion_r813135487

Cleanup: stop overwriting event target in LatexCommandInput mouse event handlers

Ref: https://github.com/mathquill/mathquill/pull/967#discussion_r851579216

Type cleanup: fix incorrect use of tuple type

The typescript port introduced an incorrect use of a tuple type for a variable length array: https://github.com/mathquill/mathquill/pull/967#discussion_r851030768

Type cleanup: use `undefined` instead of `0` to represent missing or undirected node references

Mathquill defines `L=-1` and `R=1` to represent left and right siblings of a node, or left and right ends of a span of child nodes. This convention allows swapping left...

Merge in the desmos fork

Note this is part of a chain of PRs that are concurrently under review to incorporate extensive work done by the Desmos team. The PRs all target one another in...