Jake Welton

Results 13 comments of Jake Welton

From what I understand, this will not be easy to implement. The NSFileManager does not recognize files that do not have an extension. (I've tried this and I'm getting false...

This is true, however when bypassing validation, the following line was failing: `try fileManager.attributesOfItemAtPath(path)`

@RLovelett That is a good point. NSProgress does have a flag already to support this. Commit 8e75ae3 replaces the flag with the property from the progress tracker.

@marmelroy Yeah thats a fair point. Basing it on an optional is not ideal, however if we just set it within the completion handler of the progress tracker, then we...

I've been thinking about this and have decided to change my design slightly. I've now moved over to using a block as the cancellation trigger. This block is registered once...

@marmelroy I don't mean to bother you, but I was wondering what you think of my latest solution for this problem?

@marmelroy I've just updated this branch with master (including Swift 3 changes). Are you happy with this solution?

@marmelroy I think actually we don't need to hold onto the progressTracker a the class level in this case. Tests are passing fine. Please review and let me know what...

@goa Thanks for your suggestion. I agree it would be nice to have this cancellation behaviour per process rather than all or nothing. I think however implementing as part of...

I've been looking into this and from what I can tell, its not protected with the given password. I've added a new unit test (which fails, as expected) to demonstrate...