John Shahid

Results 18 comments of John Shahid

> Can this change break old releases? We've used master branch in gitmodules, so will older tags still work? I don't think it will break old tags. From https://man7.org/linux/man-pages/man7/gitsubmodules.7.html: >...

Duplicate of #741. This pr #1004 has a fix and will be merged into master soon.

> I'm -1 to retry. It's not safe. Can you elaborate why you think it is not safe and also define exactly which action you think is unsafe. /cc @arnehormann...

@methane i had a chat with `salle` on the [maria irc channel](http://marialog.archivist.info/) and he/she had more examples for why retry may not be safe. Some of the examples are: 1....

> If your query is idempotent, why not retry at application layer? > Application knows query is idempotent, but driver doesn't know. I explained previously, retrying the query on the...

> was thinking about introducing a system property to switch to a thread-local cache as it would make sense in some scenarios (but probably not to have it on by...

I researched this a little bit more. The underlying libraries aren't thread safe. Java DOM's specification doesn't require implementation and `Xerces` certainly is indeed not thread safe according to their...

I like the change, specially allowing nil values and wrapping the boilerplate, but have a few minor comments: 1. It is unclear what type of events will be emitted 2....