John Shahid

Results 18 comments of John Shahid

I don't believe libxml2 `2.9.8` offers a fix out of the box. The fix mentioned by @tenderlove earlier in [this comment](https://github.com/sparklemotion/nokogiri/issues/1582#issuecomment-367081453) only fixes libxml2 when is used in conjunction with...

@flavorjones following up on your earlier comment. I looked into this more and it looks like opting into `NOENT` alone could cause some local file injection, e.g.: ``` #! /usr/bin/env...

I just wanted to point out that enabling entity expansion/loading (even with `NONET` turned on) can lead to XXE. We can address that by doing one of the following: 1....

@corycrowe how are you getting strings with BOM in them ? are those strings that you read from disk ? If so, can you use `File.read(path, "bom|utf-8")` to let JRuby/MRI...

we try to keep the two implementation consistent as much as we can. obviously this isn't always possible, since doing so would require non trivial changes sometimes. That said, I...

I haven't looked deeply at the C-Ruby implementation but I saw in the libxml2 docs that BOM is supported and used to set the encoding of the input stream. I...

If this information is available on the coordinating node why wouldn't a combination of running ginkgo with a new flag (sorry couldn't come up with a good name) & `C-c`...

My only concern with the files on disk is it could be harder to get those files if the tests are running on concourse for example. Collecting the information and...

Seems like the Rakefile dependencies is broken. You should be able to run `rake ext/java/org/jruby/pg/Errors.java` to generate the missing errors file. I'll get this fixed asap.

> @jvshahid Any plans to merge your work into this package? My repo isn't really a fork. I just merged the `smart` branch into master, since both had features that...