telescope-zoxide icon indicating copy to clipboard operation
telescope-zoxide copied to clipboard

Removal of `file_browser` from Telescope builtin

Open axieax opened this issue 3 years ago • 4 comments

Seems like Telescope file_browser was removed as a builtin a while ago. I've been using a custom mapping in my config to use the correct file_browser, but think it'll be nice to update the plugin so it works out of the box. I'm happy to make PR if you want, but just wanted to make sure you're cool with having https://github.com/nvim-telescope/telescope-file-browser.nvim as an extra dependency now.

Relevant change:

https://github.com/nvim-telescope/telescope.nvim/issues/1470#issuecomment-974147513

axieax avatar May 04 '22 09:05 axieax

@axieax good find! I don't use this feature myself a lot so didn't walked against this issue yet.

I added this in the default config because the feature was already available out of the box. I don't think it is necessary to add an extra dependency for all users, regarding if they use it. I think we should remove this from the default config and let users choose if they want to add.

I will make the change later and add some documentation in the release how to add it back if wanted.

jvgrootveld avatar Sep 12 '22 08:09 jvgrootveld

@axieax I'm sorry, I found little time with my newborn daughter to implement this as discussed. It would be awesome if you could help with a PR.

jvgrootveld avatar Feb 08 '23 07:02 jvgrootveld

Oh congratulations, that's very exciting news!! 🎉🎉 I've create a PR for this in #19 :))

axieax avatar Feb 11 '23 03:02 axieax

I've added this to the config and it works fine

mappings = {
["<C-b>"] = {
  action = function(selection)
    vim.cmd("Telescope file_browser path=" .. selection.path .. " select_buffer=true")
  end,
  after_action = function(selection)
    vim.notify("Directory changed to " .. selection.path)
  end,
},
},

MAXIIIMVS avatar Oct 24 '23 17:10 MAXIIIMVS