Joseph Van der Wee

Results 8 comments of Joseph Van der Wee

Hey @martinbonnin 👋 it looks like there are some changes required when authenticating websockets which aren't mentioned in the migration guide, specifically setting connection payload and refreshing token. Would it...

``` class WebSocketReconnectException: Exception("The WebSocket needs to be reopened") ``` ``` val apolloClient = ApolloClient.Builder() .serverUrl("http://localhost:8080/graphql") .subscriptionNetworkTransport( WebSocketNetworkTransport.Builder() .serverUrl("http://localhost:8080/subscriptions") .protocol( GraphQLWsProtocol.Factory( connectionPayload = { mapOf("Authorization" to token) }, ), )...

When we change the import for closeConnection ```diff -import com.apollographql.apollo.network.ws.closeConnection +import com.apollographql.apollo.network.websocket.closeConnection ``` the exception is expected to be of type `ApolloException`, so we're forced to use something like `DefaultApolloException`:...

> We can make a closeConnection() that reports a WebSocketManuallyClosedException 👌 thanks! > I would expect the server to notify its listeners directly in the websocket very good point! we've...

correct! very much an oversight on our part 🙃

That would work for us! Thanks @martinbonnin

Third this 🙏