Jake Teton-Landis
Jake Teton-Landis
@danilowoz Curious why you implemented type acquisition yourself versus re-using https://github.com/microsoft/TypeScript-Website/tree/v2/packages/ata, which is used by https://www.typescriptlang.org/play. It fetches files from [jsdelivr](https://www.jsdelivr.com/).
@orta: > As this is all still early, it might be worth looking into whether you could share one tsserver across all code samples, or incrementally loading in the tsserver...
Okay folks! This is ready for another review pass. I believe I've completed all the mechanical and UX TODOs I noted from previous comments. Thanks for the feedback so far,...
> Please take into account that it might affect the eslint tooltip too, and maybe it's worth syncing its styles in order to keep both tooltips consistent: https://github.com/justjake/reactjs.org/blob/jake--tsserver/beta/src/styles/sandpack.css#L107-L110 🤦🏻 thanks...
Typescript environments are now created on first interaction. There's an initial cost of ~60MB heap to boot the tsserver worker and create the first environment, and an additional ~30MB cost...
Hello – I have some free time coming up that I'd like to use finishing this work. @gaearon @harish-sethuraman @danilowoz What are the blockers here that I need to resolve?
@gaearon ### JS Features These apply to all the existing JS code examples: - Report syntax errors and import-related errors with red squiggles. Other kinds of errors, especially type errors,...
`sed` issue is probably a BSD vs GNU thing
I can move those commands into package.json scripts if you find that more palatable.
One of my eventual goals (per #18) is to publish the compiler to NPM; for that it would be good to provide typings for the AST.