Jake Teton-Landis

Results 129 comments of Jake Teton-Landis

I looked into enabling better memory accounting, but there's a bug in Emscripten which prevents us from using Emscripten's `malloc_usable_size` function; quickjs hard-codes this to 0 in Emscripten environments, and...

I haven’t made any progress on this. I usually find time to do maintenance on this project around Christmas, so that’s the earliest I would work on it. I if...

There is a command `yarn vendor:quickjs:pull` that I think will update quickjs. You will need to change some #ifdef for the old version of quickjs-ng still in tree. We should...

It should be possible!

Do you have any evidence the loop is actually running inside the promise? For example, if you call a log function in the loop, do you see log output?

also PS... you should rewrite this function as a `while` loop instead of recursion; your stack traces will thank you.

Fixed another issue related to global window vs child window: ```diff diff --git a/node_modules/@tldraw/ui/dist-cjs/lib/components/primitives/ButtonPicker.js b/node_modules/@tldraw/ui/dist-cjs/lib/components/primitives/ButtonPicker.js index 2bd0912..d27b73e 100644 --- a/node_modules/@tldraw/ui/dist-cjs/lib/components/primitives/ButtonPicker.js +++ b/node_modules/@tldraw/ui/dist-cjs/lib/components/primitives/ButtonPicker.js @@ -57,9 +57,10 @@ function _ButtonPicker(props) { handleButtonPointerEnter,...

We also need to check for references to the global `document`. For example in `usePreloadAsset.ts` ![TLShot 2023-04-17 at 9 02 06 AM](https://user-images.githubusercontent.com/296279/232543986-a057e563-7eff-41ab-a244-6d92b6acd9b3.png)

> Note: we are currently unable to accept contributions on the @tldraw/tldraw or @tldraw/editor packages while we work out our final licensing. ![soon meme](https://user-images.githubusercontent.com/296279/237018068-777f7bba-1220-4ed8-b1fd-fa765fda319e.png)

I think we're facing this problem as well.