Justin Ko

Results 31 comments of Justin Ko

`value.dup` is the cause of the regression: https://github.com/rmm5t/strip_attributes/pull/80/files#diff-d6d7fbebc68691eb492b2d3dff74c7841e33653fe5aae5f5f44efc99905cc5a5R64

Last I checked, Turbo Streams are opt-in ...

Try `Time.current` or `Time.zone.now` instead of `Time.now` (which doesn't take time zone into account).

Sorry, I misunderstood the issue! The problem is mysql isn't aware of time zones (unlike postgres). And the reason this isn't a major issue for everyone using mysql is because...

> Unlike mysql2/trilogy adapter, postgresql adapter sets the timezone correctly, that is why CURRENT_TIMESTAMP works correctly with postgresql adapter. 🙏 I like this solution: ```ruby variables["time_zone"] ||= "+00:00" if default_timezone...

> If I'm telling Rails "my MySQL is in local timezone", it doesn't feel overreaching that Rails would tell MySQL "I expect you to be in this timezone", when connecting....

This is when the behavior changed: https://github.com/rails/rails/commit/185f2d718d4f971ef4d45c252ec2db3db6fb0f89#diff-935494b14b54c907fc1d206871d2a4797c490b80f2c86d61a7264131dd492e42L51 Basically, for a `jsonb` column, you want the default value to be JSON! Just wrap your default value to convert it: `JSON({"amount"=>0.0})`

In HTTP headers, including the `Content-Type` header, parameters generally follow the `parameter=value` format. However, certain scenarios and non-standard or experimental use cases might involve parameters without explicit values. One such...

> Why does Rails [assume](https://github.com/rails/rails/blob/72fccfb5d665b0e16a4238e5a7c73a37f2712fa2/actionpack/test/dispatch/response_test.rb#L579-L613) parameters before charset to belong to the media type, but parameters after charset to not belong to it? Considering the simplicity or naivety of the...

Yup. Without this change a default rails app will break on Render.