Justin Ko

Results 31 comments of Justin Ko

When it's hanging, does mysql `SHOW PROCESSLIST;` or `SHOW OPEN TABLES WHERE In_use > 0;` reveal anything? On another note, it would be interesting to benchmark this to see if...

This behavior has existed forever, and I believe it's correct. In the case of a boolean column, as an example, you may want to force the user to choose the...

I can't think of a circumstance where it would be wrong, but you do remove the ability to have `false` with prompt. Maybe that's okay? I'm just skeptical why the...

I was curious and looked at other frameworks and libraries. For the ones that actually have a prompt option, they allow/require full control over whether it's utilized or not (equivalent...

It's inserting as `"[2024-01-01 00:00:00,]"`, and it looks like [Postgres will convert](https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-INFINITE) it to `"[2024-01-01 00:00:00,)"` (exclusive). Looks like we have to be explicit with the `infinity`.

All of these ranges in your test case: ``` # range = (@time..Float::INFINITY) # range = (@time..DateTime::Infinity.new) # range = (@time..Date::Infinity.new) ``` Will pass with this change: I'm still investigating...

What do you think about this? https://github.com/rails/rails/compare/main...justinko:rails:issue-51745

If you provide an [executable test case](https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#create-an-executable-test-case) I'll take a look.

Your test case doesn't fail with Rails `7.1.3.4` or `7.0.8.4`.

These work and are equivalent to each other: ```ruby where.associated(:challenge).merge(Challenge.arena) joins(:challenge).where.not(challenges: {id: nil}).merge(Challenge.arena) ``` So it seems like it needs a where clause to retain the join and not result...