Justin Horvitz

Ran into this because my current work is encountering a bit of additional complexity due to the magical appearance of additional empty files when creating runfiles symlink trees.

I've started to look into this and have some bad news. I ran the new parser over google-internal checked-in blazerc files, and on a sample of over 700 files, the...

Or another option is to display a warning for the single token case that's currently ignored. Would this solve your motivating scenario?

Actually, seems tricky to have a flag that controls the semantics of flag parsing. Might need to be a system property. Makes it seem more appealing to just add a...

In the single token case, we could use an empty string. Then the server would error if the single token is not a valid command name. That would push all...

When passed an empty string with an invalid command name, it works (currently a warning today). When passed an empty string with a valid command name, it adds the empty...

Fyi - we no longer need this feature for Bazel, as we found a way to pack the keys into the values.

Since you have feedback from other reviewers, and I have no experience with virtual threads, I removed myself as a reviewer. Please let me know if you want me to...

Quick minimal demo of the issue: `foo/defs.bzl`: ```bzl def _write_conflicting_runfile(ctx, content): o = ctx.actions.declare_file("conflict") ctx.actions.write(o, content) return DefaultInfo(runfiles = ctx.runfiles(files = [o])) def _compilation_mode_transition(mode): return transition( implementation = lambda _,...

@fmeum You sent me a private message last week I think related to this change but now I can't find it, I believe due to default chat retention. Please try...