Justin Johnson

Results 34 comments of Justin Johnson

@lidel When you have time, gentle bump on getting your feedback to the comments above. I really appreciate the time and feedback you've given me already. πŸ™ At this point...

FYI, I'll be out for a few weeks but will be checking email in case there is any PR feedback. I'm sure there will be things to address but I'm...

After some discussion with @b5 and @dignifiedquire, I'm leaning toward pulling out forced redirect support to avoid a performance hit for anything other than non-existent paths (i.e. read `_redirects` file...

Review status... @lidel is wrapping up specs for existing gateway functionality and then hopes to get to this, possibly next week or the week after.

@lidel I believe I've addressed all feedback now. From my perspective the only question that is outstanding is https://github.com/ipfs/specs/pull/290#discussion_r944384586. I did add code to handle these extra http status codes,...

@lidel regarding broken tests, I'm waiting for you to merge changes in go-ipfs-redirects-file first. πŸ™ I'll take a look at the diff you sent, and today I learned about `git...

@lidel your diff's are now pushed on my branch. All tests pass locally for me when go-ipfs-redirects-file is replaced with my local clone.

The changes are in and ready for review @BigLep πŸ™

@lidel thanks a ton for all the work you put into this!

I think it’s universal. We don’t have a CODEOWNERS file and drafts still show up in Slack.