Justin Chu

Results 466 comments of Justin Chu

Looks like the tool is available on pypi https://github.com/yoheimuta/protolint?tab=readme-ov-file#within-python-projects I recommend it is added to lintrunner adapters for a unified linting experience

We will create a follow up for it. Thanks!

@yuanyao-nv I think the branch cut has been made and you may be able to rebase and move your PR forward

Is there a reason you need to script the module?

pytorch-geometric may not be supported, will need verification. But I would still recommend using jit trace over scripting when possible. Additionally, torch jit is in maintenance mode. Please test with...

onnxruntime shouldn’t be imported at torch import because the whole torch.onnx module is lazily imported. Did I miss anything?