Justin Chu

A challenge for us to standardize it into an op I heard from previous discussions is the number of variations in attentions. For us to support PyTorch in particular, we...

Ref: https://github.com/microsoft/onnxscript/blob/c74bc6a8993436c6516af723d3622170e75b4a1a/onnxscript/function_libs/torch_lib/ops/nn.py#L1633

cc @xadupre for approval

Looks like some things crashed

There is quite some usage: https://github.com/search?q=%22BUILD_ONNX_PYTHON%22&type=code. I don't think we can remove it yet.

Is it used anywhere else? https://github.com/search?q=repo%3Aonnx%2Fonnx-mlir%20onnx_proto&type=code maybe?

I am hesitant without understanding the full impact. Could you explain the benefits of this? It seems the onnx-mlir project doesn't link the other targets from this project just browsing...

Will there be cases when projects do not need the target onnx, just onnx_proto?

Maybe @AlexandreEichenberger can weigh in?

Related discussion in https://github.com/onnx/onnx-mlir/pull/3182#issuecomment-3185854377. Should we reconsider this change?