Justin Hopper

Results 34 comments of Justin Hopper

@adidahiya I think at this point this should just be considered a documentation bug. The docs say "Useful when rendering a `Collapse` inside a ``, for instance.", but really it...

> But I'd like also provide the option to leverage webpack/rollup tree shaking. A package global singleton approach seems like it could work: > > ```ts > import { Icons...

@adidahiya I ran into this same issue recently. A typical reason for a fragment is due to needing conditional sections, such as: ```jsx {isAdministrator && ( ... )} ``` Some...

@compulim Please consider pulling this in. The React team has stated clearly that React 17.0 is fully backwards compatible with 16.4.0+, and this addition would help silence warnings during npm/yarn...

@compulim You can publish typings even without writing your component in TypeScript. The way you do this is simple - add a .d.ts file with the type definitions, and then...

@compulim Can you please review this?

@shadigaafar You should post your package.json if you want others to be able to help further. @compulim I think you should consider adding React 17+ to the peer dependency rule....

While css variables would be easier on end-users to override, I imagine it would be challenging to migrate to given the amount of sass math/operations that are happening with sass...

@khellang I agree, `FromExecutingAssembly` makes sense and it can use `Assembly.GetCallingAssembly` internally. Although I would think it that would be a breaking change, I think it might be safe to...

If I'm reading this correctly, you're saying that `FromCallingAssembly` might return the expected assembly in special circumstances if inlining occurred? If so, it seems doubtful that inlining would occur under...