Justin Frahm
Justin Frahm
@comcalvi, based on what I learned in #20281, I think we'll eventually have to reopen this pull request from a personal fork of `aws-cdk` instead of this organization-owned fork, since...
Ok, I detected the `Names.uniqueId` bug in an existing unit test and added a two-part integration test. I can look into adding some more unit tests for further coverage next.
Had to roll back an update merge since it seems to have introduced a build error - something about `cxapi` not having an expected attribute.
> This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not,...
> Hello, for better visibility, I will restate here what I added in the comments: > > Feedback has been provided already and the ask is to fix the failing...
@Naumel, @TheRealAmazonKendra , is this still on your radar? I hope somebody can get back to this before I have to do another round of fussing with merge conflicts.
Thanks for the reviews, @comcalvi and @MrArnoldPalmer . I'll try to address the new comments not part of a PR review change requested here: > This PR makes a number...
@comcalvi ?
> Sorry I wasn't more clear; I do not understand this mechanism. The main thing I'm missing the usage of filterReasons(). What does this function do? Why do we need...
> What doesn't make sense to me is why we need to filter the dependency reasons. What problem does filtering dependencies sovle? Sorry for the slow reply - I've been...