Jure Triglav

Results 41 comments of Jure Triglav

One test is failing/timing out on Firefox: adding AR state. The same test is failing on master, however, so it’s unrelated to this PR.

So I did a bit of exploration and it looks like this is used quite a lot in the community: https://github.com/search?q=sphericalEnvMap&type=code. In this case, perhaps the best way would be...

Just rebased this upon the latest master, so that specs pass. Still interested in feedback about the actual contents of the PR! 1. Should we remove sphericalEnvMap as this PR...

Three.js's own migration notes include this notice: "SphericalReflectionMapping is no longer supported. Consider using a Matcap texture with MeshMatcapMaterial instead." For future reference, this is the PR that removed it...

You're misusing the `preview` connector. The `preview` you receive back from `useDrag` is a: >Index 2: A connector function for the drag preview. This may be attached to the preview...

We've been hit by this issue today and were quite surprised to discover it's an ancient bug in node-gyp. Any reason why this can't be merged and #65 fixed?

Thanks for looking at this! Unless the partial fix breaks something else, and it doesn't seem likely, perhaps it's a good step into the direction of supporting spaces in build...

I am also seeing lots of diffs in the snapshots, indicating that `jest-styled-components` doesn't do its class name magic in some cases, e.g.: ```diff ``` Happy to help out if...

@byronmejia no, unfortunately we don't use this way of referring to components. For example, the component that now shows the hashes instead of the `c0`, `c1` stuff is: ```js const...