aframe-blink-controls icon indicating copy to clipboard operation
aframe-blink-controls copied to clipboard

Published 20 hours ago • verified publisher icon jure

Rename PlaneBufferGeometry to PlaneGeometry

Open vincentfretin opened this issue 1 year ago • 1 comments

Rename PlaneBufferGeometry to PlaneGeometry to remove warning in threejs r144 used in current aframe master.

PlaneBufferGeometry was renamed to PlaneGeometry a while ago but in threejs r144 they added a warning "THREE.PlaneBufferGeometry has been renamed to THREE.PlaneGeometry.", see https://github.com/mrdoob/three.js/commit/5acd8ce2cfb7fc29b4fde9775e46041ace9bc055

If did a similar fix recently in aframe https://github.com/aframevr/aframe/pull/5114

vincentfretin avatar Sep 16 '22 10:09 vincentfretin

When I say a while ago, it was around aframe 1.2.0 threejs r125, this was already the case https://github.com/supermedium/three.js/blob/super-r125-1/src/geometries/PlaneGeometry.js#L81 so I think this is safe to merge.

vincentfretin avatar Sep 16 '22 10:09 vincentfretin

Thank you, @vincentfretin!

jure avatar Sep 17 '22 19:09 jure

When you have some time, can you please do a bugfix release with the change? Thanks.

vincentfretin avatar Nov 05 '22 14:11 vincentfretin

Thanks again, @vincentfretin! Released as version 0.4.1.

jure avatar Nov 05 '22 20:11 jure