Juniper Tyree
Juniper Tyree
@aljen Thank you for submitting the PR! I've left some thoughts above :)
No worries, happy New Year! Do you want this PR to go in the suggested direction of serialising all integers as hex / octal / binary? It would require a...
@davidhewitt what are your thoughts on this?
@davidhewitt I apologise for pinging again - I'm hoping that this PR could move forward soon-ish as I'm working on publishing a crate of mine (which would need a feature...
@davidhewitt Congrats on shipping pyo3 v0.22, I'm excited to start using it! I'm looking forward to collaborating with you to push this PR forward :)
The merge conflict should now be resolved again :)
Once #66 is merged, I will very quickly rebase this PR again so that we can hopefully still get it into v0.22
GATs were only stabilised in 1.65 but pythonize uses 1.63 … so the builder can’t use a GAT. Perhaps I can inline the builder methods into the main trait itself...
I also tried to add a small convenience wrapper type `PythonizeUnnamedMappingWrapper` so that 1. it is more explicit that `type NamedMap = PythonizeUnnamedMappingWrapper` discards the name 2. it is reusable...
Thanks for your review @davidhewitt!