Juniper Tyree

Results 292 comments of Juniper Tyree

Do you mean during serialization (unfortunately impossible since serde doesn't give us any information) or during deserialization (should already be working on the 0.9 pre-release version)?

Since this is an issue with serde, I'll close this issue

I also really like `#[repr(type = ...)]`. It allows greater flexibility in the future without clashing with existing reprs that are assumed to have an unambiguous meaning. When I read...

Thank you @voidentente for your PR and the extensive motivation! I absolutely agree with the motivation for adding attributes in general and doc comments as a first step towards them....

> Well, I expressly wanted to keep the extent of this PR as scoped as possible. It's based entirely on top of the comment syntax, because I'm unsure of the...

What this PR would still need is tests to ensure full coverage and to test how field docs can be added e.g. to a struct nested in an enum inside...

API-wise, I think the meta field on PrettyConfig should be of an new Meta type, which then exposes a fields() method, so that we could add support for different accessors...

Sorry for the delay in the review, things have been hard

Thank you @voidentente for your continuous work on this PR - just a few more nits and I'm happy to land this