Juho Eerola

Results 19 comments of Juho Eerola

Something like that, yes. I wasn't aware of the plans for it in c++23, thanks for pointing that out It could also be made with iterator pairs like `zip(a.begin(), a.end(),...

I totally agree, algorithm with no use is essentially dead code. The main reason I started this discussion, was because I was thinking whether or not `zip()` would be beneficial...

The cause seems to be `ncr(NAN, 1)`, which goes into pathologically slowly advancing loop for some reason. Printing the values with `%lu` format just before the loop, I got: ```...

I've also ran into this occasionally. The crash reports pointed to `sqlite3DbMallocRawNN` on top of the faulting thread's call stack. When enabling address sanitation with `-fsanitize=address` the process crashed bit...

The lock in question is the feed's `item_lock`. This is first taken by `do_update_visible_items()`, and then later in the call stack by `unread_item_count()`. https://github.com/newsboat/newsboat/blob/cc4a932251b68a3d45922e876b0a32c44dc6a333/src/itemlistformaction.cpp#L924-L930 https://github.com/newsboat/newsboat/blob/cc4a932251b68a3d45922e876b0a32c44dc6a333/src/rssfeed.cpp#L82-L84

Shouldn't `nand(a, b)` be `not(and(a, b))`, not `and(not(a), b)`? Or maybe it should be called something else? Also flipping selected bits can be done with xor: `xor(0xF, 0xFF) = 0xF0`....

One thing that came to mind. It might be helpful to add a mention about bitnot being "missing" where the other bitwise functions are listed. And maybe add an example...

Hi, I happened to also port the parser few weeks back (just for fun, I was bored). I ported the tests from c++ as well, which also work with your...

> Let's keep this PR on a back burner for now, and return to it once we can guarantee that Rust will only see UTF-8 inputs. That's understandable. In the...

Added changelog entry. For the tests I went with the extra macro argument for additional EOL checks for now, let me know how that looks to you. What's the practice...