Junho Choi (최준호)

Results 26 comments of Junho Choi (최준호)

> I'm split on whether this is worth the maintenance burden. I have a same concern that this will add some more code complexity but there was already a number...

It just works ok but we might need to remove some duplicate steps (e.g. does doc to run every OS?) to reduce the build time.

> Nice! Why only run on `matrix.tls-feature == ''` Because it seems redundant on other tls features. Also installing cargo-machete takes some time. Instead we can try cargo-quickinstall to save...

Looks like related to https://github.com/cloudflare/quiche/pull/1769 I made a suggestion on your homebrew PR.

So the main issue here is when #1769 added it only sets SONAME in the shared lib, but since we don't have an installation step, creating symlinks need to be...

Homebrew formula has been updated to 0.22.0 and merged. https://github.com/Homebrew/homebrew-core/pull/176665 @chenrui333 thanks for review! you may close this ticket.