Jonathan Underwood
Jonathan Underwood
Thanks. That lowers the scope of the review significantly. I'll take another look later today.
Deployed successfully! https://bitcoinjs.github.io/bitcoinjs-lib/ Maybe add this to the README?
Ooh, that sounds like a good idea. I'll see if I can whip something up later. If anyone wants to work on it let me know.
Basically: 1. If it's provably unspendable (OP_RETURN et al) then 0 sats is ok 2. If it's segwit then use 67 bytes if not, use 148 bytes 3. Add the...
Questions: 1. Add a parameter to represent MIN_RELAY? (I checked and it's not based off of the eject level, it's based off of the min_relay parameter (which defaults to 1000)...
Check out the PR.
I guess it really doesn't matter. We can change it later. Just check it out and make sure it jives with the Core code.
No it'll be closed when we merge it.
Are you sure you don't mean to `addInput`?
Adding a getter and setter might be helpful, but if you mean `partially finalized PSBTs` as in "the data in the finalScriptWitness is not actually finalized" then I am against...