Jonathan Underwood

Results 435 comments of Jonathan Underwood

Please post your versions for node, npm, etc. and create a minimal reproduction that we can try to reproduce.

Users should not import functions that are not exposed publicly. That is correct. This issue is making an implicit assumption that these functions MUST be exported, but they aren't. ---...

Keep in mind, helper functions that we use internally are sometimes explicitly not exported because we don't want to commit to their interface. ie. If you import them like you...

re: the taproot functions, I defer to @motorina0 since I'll be pinging him whenever someone requires something changed to the public interface of these functions IF we make them public....

Your code doesn't do anything with bip32. It creates the `node` variable and does nothing with it. You essentially are just using `ethers.HDNodeWallet` and `KeyPair` classes. (although I don't see...

Pass `node` instead of `keypair`. I don't even know what `keypair` is... where did `KeyPair` class come from? Does `KeyPair` implement the BIP32Interface? I'm guessing not, since you say there's...

This still doesn't tell me what `ethers` is or `KeyPair` is... Did you read the examples? [Like this one?](https://github.com/bitcoinjs/bitcoinjs-lib/blob/v6.1.1/test/integration/bip32.spec.ts#L103-L120) In this example, the variable `child` is a BIP32Interface

Please read the example I posted. --- In response to your explanation: Yes, I know what ethers is. When I say "What is ethers?" it means "What is this doing...

Please click this link and read the example: https://github.com/bitcoinjs/bitcoinjs-lib/blob/v6.1.1/test/integration/bip32.spec.ts#L103-L120

Taproot support is added now in v6.1.0-rc.0