Junchuan Wang

Results 28 comments of Junchuan Wang

> Though the naming was bad before, the need to pass executor as an argument would've given enough hint to the user about the behavior. Also, most of the existing...

@karthikbalasub @evanw555 I do see benfit of using `Task.callable(name, callable, executor)` (it is cleaner). But the problem is it seems that in ParSeq history, callable and callableInExecutor (or blocking, as...

Link to https://github.com/linkedin/parseq/issues/289

@jodzga Hi Jarek do you have more description for this issue

Hi @hepin1989 Sorry for the late reply! Thanks for submitting the change! May I know the motivation of the change? From what I see, there is quite limited improvement. Since...

@jjoyce0510 do you think you can raise a PR? I will review it. My hunch is chaging the import path name ( org.codehaus.jackson vs com.fasterxml.jackson.core) is the only thing needed.

> @jjoyce0510 @junchuanwang : I have made the required changes but don't have permission to push these changes or create a PR. I have attached a file containing the changes....

Hi in this PR, you should keep the consumer of `BaseEngineTest` the same to test if it is backward compatible, because you are renaming `BaseEngineTest` Do you think you can...

I think this is backward-incompatible change, isn't it? Any existing user of `BaseEngineTest` if keep using `BaseEngineTest`, will potentially fail if their test cannot be run in multi-htreaded environment. @Anmol-Singh-Jaggi

Thanks Mars, we already have internal task tracking this issue