Alexandr Juncevich

Results 22 comments of Alexandr Juncevich

Also, you may rebase you commits in one commit.

@skjolber Netty with Micronaut.

I've offered not to convert body to string in method `byte[] getBody()`. I suppose when when someone asked body in bytes - bytes must be raw. There is no need...

Yep https://github.com/zalando/logbook/blob/c54d0cb046651201499cebb952016222d89fd3d0/logbook-core/src/main/java/org/zalando/logbook/FilteredHttpRequest.java#L78

@whiskeysierra Will we fix these problems? I can do it)

> > Useless converting raw bytes from request(response) bodies broke protobuf model deserialization. > > @juncevich Just curious, do you just use protobuf over HTTP? I'm thinking how to integrate...

> @juncevich can you please elaborate on what these points mean? > > > job task time consumption > > iteration time consumption > > It will help reviewers understand...

Hi [siddhantsangwan](https://github.com/siddhantsangwan). Can you review my PR?

> @juncevich can you please check test timeouts / failures? > > ``` > org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerDatanodeNodeLimit > org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerStatusInfo > org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask > ``` > > https://github.com/juncevich/ozone/actions/runs/11380961580/artifacts/2067990610 Thanks for the comment. Tests fixed.