Julius Tens
Julius Tens
yes (:
Cancel(l)ed state LGTM, I'm not sure if it would be wise to set the `departure`/`when` to `null` though, since that would take away useful information (e.g. if you want to...
(Sorry that it took me so long to respond) What about delay information when a trip is canceled? IMHO that information should be kept as well. Would make more sense...
> Not sure if the former delay is that relevant. After all, the departure/trip has been cancelled. For example when recording which trains have been canceled, there might be a...
> I consider this a niche use case. Because we may not even have this information, I'm against adding formerDelay as a required field. I never wanted the field to...
Please note that **instead** of `formerScheduledWhen` we would have `formerWhen` (+ optional `formerDelay`) then. > Shall I add it to #31? Yes 🙂
I don't get your point. Either you have delay information on the canceled route, then my proposal is not a problem (?). Or you don't have it, but calculating the...
I feel like this is inconsistent. We should either use `scheduledWhen` + `delay` in non-`canceled` routes as well, or use `formerWhen` and `delay` in `canceled` routes. Why use the `scheduled`...
Sorry for being so late to comment, IMHO we should be consistent with the decision to make operator required/optional, e.g. also in `line.operator`. I personally would rather have it *required*,...
We should also decide on #55 while we're at it.