Julien Wajsberg

Results 515 comments of Julien Wajsberg

Can you elaborate somewhat which actions are slow ? :)

They're sorted in https://github.com/firefox-devtools/profiler/blob/af62509321b9610b7acacb7e4094eccd99945a35/src/selectors/per-thread/markers.js#L132-L134 I'm pretty sure we don't rely on them being sorted in the pieces of code that deal with them in the raw tables. However the marker...

The UI looks good to me! I'd just add some hover on the dropdown so that the affordance is good.

> We will need servers that can serve the assembly for official builds Wondering if we could have that locally through the addon. (no other comments, all this sounds quite...

@andrapetronela yes sure ! This will require understanding what the SVGs mean. I think the best way is to write some description of what you understand, and then we can...

As we discussed with @andrapetronela, this bug needs somebody who's already quite familiar with the codebase. Unassigning Andra then!

> In #833 there were concerns raised about any type of setup logic being done in the describe block, even if it is immutable data. To be clear, what I...

There's pretty much a consensus on how to write tests and we should document basically what Greg wrote. The part about Sinon is moved to #1977.

Thanks for the write-up, indeed it would be good to include this information in our documentation. Thanks for the suggestion. To clarify a few things: * Currently we do not...

I believe most people I know are using this feature using window.open, but that said it's not a bad idea. It would be good to limit it to /from-post-message though,...