Julien Wajsberg

Results 515 comments of Julien Wajsberg

Hey @zbraniecki, by chance would you have some guidance or documentation about how to use pseudolanguages with fluent.js/fluent-react in a plain web page (as opposed to in Firefox)? Thanks!

Thanks for the pointers! This is what I did to support pseudo locales in the profiler: https://github.com/firefox-devtools/profiler/pull/3188 We enable a pseudo locale by calling a function in the devtools console....

I noticed that the `lang` property isn't set either (it should be set to the locale used). I noticed that the devtools folks set the `dir` property manually: https://searchfox.org/mozilla-central/rev/69babd862de70cabfa1d0a369d38e4881bd41e4d/devtools/client/aboutdebugging/aboutdebugging.js#77 In...

I am under the impression that fluent-dom doesn't do it either. In Firefox [there is a adhoc mechanism](https://searchfox.org/mozilla-central/rev/69babd862de70cabfa1d0a369d38e4881bd41e4d/dom/l10n/DOMLocalization.cpp#446-464) to do it automatically, but that it's not implemented in the generic...

There are test errors: ``` * jest_v22.x.x/flow_v0.39.x- (flow-v0.66.0): Unexpected Flow errors(0): Warning ------------------------------------------------------------------------------------ 0-test_jest-v22.x.x.js:52:1 Unused suppression comment. 52| // $ExpectError Mock function expected to return Promise, not Promise. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Warning...

Yep totally, the error definitely comes from my typing :-) I don't understand why the typing doesn't yield these errors and were seeking for some help.

Yes, actually, that's what I said in https://github.com/flowtype/flow-typed/pull/1918#issuecomment-370839427 :) I don't know how to fix these problems and I'd like some help here. Basically, Flow doesn't report errors here while...

[From my test](https://flow.org/try/#0C4TwDgpgBAogHsATgQwMbAAqIPYFsCWAzhAGrIA2ArhAGKUB2qUAvFADxlUQB8AFFniIQOFatwCULblE7UA3AChQkWAhToBBYrOGahO6awAkAYQrk2CqKqRpMOLaVG0GqADRWoe7c4XdF1tYKqOTIhIReyCi4EEj4AF4QACYmoeFsACrSAN6eUMDIANZOXLwAbhQAXFAZktkAvnkFxd4l1OVVNur2gj5cmRJQDQqNgVDB2PSEwFBgUcgxcYlJOgCM1Rjzi4gJyalhhGz0lLgARhCIhlD0EADukdGxO8v74bziAYEKc49LyWsAOmabQgvFWH2+WyeuxWzlWQKKEFaOjBELGEymMx+C2hyx0ACYNlC-ik0odWkcTudLlcbvdNr9nnsye9FNjtjCCQjiijWgDEBBCNhyGVQeCIezcf9nPjuUiHPpnKi2cSmbCuLLgcilQAiABm2GwOrRY3GQA) the `ExtractPromiseValue` util should work. I'll give it another shot.

[I simplified the problem in try](https://flow.org/try/#0C4TwDgpgBAogHsATgQwMbAAqIPYFsCWAzhAGrIA2ArhAGKUB2qUAvFADxlUQB8AFFniIQOFatwCULblE7UA3AChQkWAhToBBYrOGahO6awAkAYQrk2CqKqRpMOLaVG0GqADRWoe7c4XdFSuDQAFIQhMAAstioANY09GwAKgCCiADmlLgQ9MCEAFxQRgBKEMgAJgDy9OQgqSggbABU3G5QiSXAlIj0hlAA3p68AHQjyOn5bakZWTmE4gXtEJ3dHtYA9I2NnlCNUAAiEGCIEKjIwBBlBZTEUABWYcBDAGb0vLySzNIAbs6S+PThUplbaNNaeXDRGIdLr0HS8H5cBbQ7rzKChcJRWLxJJTTLZXKtRbLHqrKAbLbWHZQADKlDSYygT2wiCg2GqICgx2J-zSUGQUAR1FZjGg-0I+DK0BA2C6UAhsRBYOs8qhSxhOiqqAg8OcSLVKIK6MikOxKXSeNmhORJIUnnJIJpdIZT1cwHwbMIjOZnP19B5fJ9hGw5C+Fy8DiEUF4RoFACZY0NYwBqcSK8GQkpBkMXOHbAW6mzqeyCHxcJLW7ieVFGzFxBJm6b4whW30tW3KjNhYOhsoakW8POCiAFeC2DQR0vUcutquGh61024mYEtoVjx2zYO2n0lkuxhuj1ellcmH+-nHe7oMPeaDRh5xhPJ1OU0Hp2IlS-nXvOHWIvn0EBq3nE16yXJsW2JNsO3fCBPxzZxNW1IcCmQACgIxECcXNZdm1XGcAF9FEpSlAhUI0KgAI0-RIghYfoNwpaxdmtT1+XoCAAHdWgYa4wxVRlXXdeghjTawXiwxtZgKYogSqGo6mQBpmggmE+HQ40sVA7DwLwyCPEI21JVQcgxmgH4WXucI53CSjqKCAJlGgGhsGwOi+gAH08MpsGpTonieApwkQf1PigehMgoiBEFJbzkkIEBGF8yh-IKL5sAlKRwxLYRwtwSLEErdyDNQD1gC9bACmc1zWAGaxvKS-zeCCwKkB5VFcvy+jiJPbooAAViIqB8Ji7A4oS1AGqed4ChvNgOqi6RaspHr6CyxwhmOLNQ14PrxEG-CFAM4jrAUJlsCGWL4sSvynjoyzHhed4hhVTNu3grheAARgABj206XIu0aromm67oeZ5XnEZ7O2JOEbw2rtsy+36-uOqAFDWNZCngSB0BgRAcBZWsBP3ISoAgOBca-KBgFcla1qEOaIoW1p6GwMrZqCnluBEs7AbG67ktu1h7ohp6XsRns4QAIh+6W-sx7HKZOYB8cJqAzHoAByMr6f5G9GQcAM2dW5BgZJ9AhP+876tBkXwceqGJa297qGRv7rf54HJrB8IxadzsXe-LhEPdxQ+cu8afftv3HehmDYYQ-t4c2t73dR46MaxowcZVtXvWJvdLbZcnlavMoabp30GeIJm8pZsL2Zr4QufoNIec9yPBf832Hsh+PVSDvstV4WXvvlxRFZzsvVYJ71NZ1n1iQDA2niNtiS7N8aLYPehO58u27gd-vnbe4PqFDn6-qAA). Maybe the problem is how Flow infers the parameters to `JestMockFn`.