Julian Storer
Julian Storer
Like for your other pull-request, this seems to have dragged in a bunch of other random changes - can you do a rebase or something to make it clear what...
I can't make sense of these diffs, can you do a clean rebase against the tip of develop so I can see what you're actually trying to change? But TBH...
I'd find it much easier to say how good these changes are if I could see them. It's not just white-space, it looks like you've reverted a bunch of other...
...oh, unless it was you that deliberately added all those autos and consts? That seems likely as they mostly break our style guide! Please don't attempt to refactor when you're...
To be fair, the coding standards doc is way out-of-date and our new one hasn't made it to the website yet.. Yes, the auto and const stuff was just different...
OK, I see what you're trying to do, but this really doesn't fit for several reasons.. The URL class is a by-value class, so can't have mutating methods, and would...
Wow, very cool! We had been meaning to get around to learning about LSPs and how to do one. Great to see you doing this!
BTW, I have some thoughts on this, as I've been working on related stuff this week - maybe can chat over on theaudioprogrammer.com discord channel or somewhere like that?
Sorry, I only just noticed this PR. It's a bit hard to see what you're actually changing because the diff is pulling in thousands of other changes, so you might...
Yep - absolutely, it *should* work, and one day we will make it work, but for enormously complicated reasons, it's a really really difficult one to fix. We've had it...