Julian Gruber
Julian Gruber
hmm, i can't find a way to reproduce unfortunately
@geekytime great investigate work! can you post what you wrote to test this bug here?
That's not straight forward to add with the browser-launcher dependency...maybe try coming up with a pull request for browser-launcher, then we can add this here
i used to use browser-launcher2 but switched back to browser-launcher because that was working better for most cases. i'm happy to merge something in if it works well, but currently...
i just looked through the history and it seems like this never actually used browser-launcher2. i'd be happy to accept a pull request to move to that.
You could set up a Linux Vm for running this project, so you have a good starting point. This error `spawn phantomjs ENOENT` shows that maybe on Windows we should...
We could try that, but I'd rather add a flag instead of detecting the module type, for now at least. Would you be interested in working on a PR for...
Do you have a suggestion how to fix this?
Ah, so you're using this through tape-run?
I guess we can just add another timeout that will kill the browser child_process if window.close() fails