Julian Descottes

Introducing a new preference and testing it with launchpad can be tricky. The new preference has to be added in one of the devtools preferences files in order for it...

Update script result_ownership tests to handle id is only on root

3

Per serialization spec, child ownership is always set to "none" before serializing values. This means that only the root can ever have a handle id set. Our current tests for...

Only accept valid tag names in Find element with "tag name" strategy?

1

This question comes from the following geckodriver issue: https://github.com/mozilla/geckodriver/issues/2007 Chrome/chromedriver currently throws if Find Element by "tag name" is used with an empty string as the tag name, whereas Firefox/geckodriver...

[bidi] Test "Target should not report uninitialized pages" expects no navigationStarted event for window.open

4

We are implementing the navigationStarted event in Firefox, and with this event the following test now fails: https://github.com/puppeteer/puppeteer/blob/3238b93a79b9e6891c00a32ca009057fb7425a68/test/src/target.spec.ts#L224-L248 It seems we expect no navigationStarted event when calling `window.open('about:blank')`, but I'm...

Switch to macos 13 arm

1

Just trying jobs 13 arm

Stop supporting backward compatibility until we have a technical solution to support it

8

After working on remote debugging for a few months, I have started paying much more attention to backward compatibility breakage than before. We already had RFC #51 to discuss backward...

Preview images should be centered, and should not show a checkered background

1

When a sprite is not square the preview on the gallery looks really bad:  We should center the image, and have a less contrasting background (with regards to the...

Allow the use of folders to organize the Gallery

3

_From @guilnunes on September 1, 2014 19:25_ Is it possible to create folders to organize the artwork in "My Gallery"? It would be pretty handy with the growing number of...

Suggestion: Batch actions on gallery

1

_From @guilnunes on April 30, 2015 13:43_ I think it might be useful to have: On the gallery screen, add a checkbox on the image thumbnails, so you can use...

HTTPRequest is checking for chrome-only error message "Invalid header"

2

Puppeteer expects that errors about headers will contain the message "Invalid header", both in the implementation and in tests: https://github.com/puppeteer/puppeteer/blob/7712dffffef49282889ec99c1f0a066b826c2988/packages/puppeteer-core/src/api/HTTPRequest.ts#L705-L713 https://github.com/puppeteer/puppeteer/blob/7712dffffef49282889ec99c1f0a066b826c2988/test/src/requestinterception.spec.ts#L763 We should find another way to handle this in...