Julien
Julien
Sorry, it's on my todo list but had no time for it for now. maybe in a few weeks.
On default values, there are the ones I used and would recommend. There are obviously very context dependent but IMO, I prefer a secure default state with known documentation and...
Like mde, good for review and merge.
As said, would need a bit of help on mypy error as less familiar with the tool. Also, for some reason, CLA check is not green, but when going to...
Ah,CLA check is green now
on my side, linter looks all good. only pyupgrade is failing but not related to code and did recent change to 2.31. 0 (3.2.0 works ok for me)
I added custom settings https://github.com/pandora-analysis/pandora/commit/11a407f490015c9e1e6508b88568d58d7a335533 https://github.com/pandora-analysis/pandora/compare/main...juju4:pandora:devel-workflows On my side, that's one reason that I put lint in a separate workflow. I don't want unit/functional tests fails because of new lint...
On line length, I put 160 for black, flake8 and pycodestyle but this was not applying to devel-black branch. here one where it is applying https://github.com/juju4/pandora/commit/39a903d62aa23f088618a2b11de7e264129ec878 flake8 is still giving...
from search on black features, it does not seem possible to globally ignore line length. In the same way than flake8 and pycodestyle, you can only customize max length. But...
Added few exclusions for bandit. only low severity left. PR https://github.com/pandora-analysis/pandora/pull/112 Note: some of those can be added to pre-commit too like black or pylint