judyjoseph

Results 62 comments of judyjoseph

@maksymbelei95, Could you please resolve this conflict before we merge it in - thanks.

@ysmanman please let us know if you were able to check if this issue is resolved with https://github.com/sonic-net/sonic-buildimage/pull/17962

@JunhongMao I understand that with this PR and https://github.com/nokia/sonic-platform/pull/6, trying to have the shut/start of SFM + swss/syncd processes in the nokia platform submodule. Can we make this a bit...

Thanks @Azarack for addressing comments and sorry for delay from my end. Could you add this new test in the same file : [test_deployment.py](https://github.com/sonic-net/sonic-mgmt/blob/7789f24847943a81f95f3d190818e2da3d8db1fb/tests/macsec/test_deployment.py). As this is a deployment usecase,...

@Azarack Can you add this testcase as part of the existing macsec testplan ? https://github.com/sonic-net/sonic-mgmt/blob/master/docs/testplan/MACsec-test-plan.md https://github.com/sonic-net/sonic-mgmt/blob/master/tests/macsec/test_deployment.py

@mlok-nokia the ethtool is not present even in 202205 branch of build_debian.sh. Were we installing it via sonic-platform https://github.com/nokia/sonic-platform/blob/e82caa40d4eec59e574bd4acffb0e92fd7187da4/debian/rules#L43 earlier ?