[Test Plan] Macsec neighbor reboot

[Azarack]

Description of PR

Summary: Adding test to verify macsec functionality when a neighbor reboots.

Fixes # (issue)

Type of change

• [ ] Bug fix
• [ ] Testbed and Framework(new/improvement)
• [X] Test case(new/improvement)

Back port request

• [ ] 201911
• [ ] 202012
• [ ] 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Vsonic neighbors only tested

Supported testbed topology if it's a new test case?

T2

Documentation

[rlhui]

@Azarack , file changed is missing, thx

[Azarack]

@Azarack , file changed is missing, thx

I see what happened, correcting it now.

[Azarack]

@wenyiz2021 can you review this PR?

[judyjoseph]

@Azarack Can you add this testcase as part of the existing macsec testplan ? https://github.com/sonic-net/sonic-mgmt/blob/master/docs/testplan/MACsec-test-plan.md https://github.com/sonic-net/sonic-mgmt/blob/master/tests/macsec/test_deployment.py

[Azarack]

@Azarack Can you add this testcase as part of the existing macsec testplan ? https://github.com/sonic-net/sonic-mgmt/blob/master/docs/testplan/MACsec-test-plan.md https://github.com/sonic-net/sonic-mgmt/blob/master/tests/macsec/test_deployment.py

@judyjoseph I added the steps from MACsec-neighbor-reboot.md to MACsec-test-plan.md, but I don't see what updates you are asking for in test_deployment.py. Should we be adding to existing test plans for new test cases and not adding new test plan files?

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/MACsec-test-plan.md

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/MACsec-test-plan.md

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[Azarack]

@judyjoseph @wenyiz2021 Hello, can you review my comments to your previous reviews?

[Azarack]

@judyjoseph can you confirm if your requested change has been completed?

[Azarack]

@BYGX-wcr Please review this PR.