Magnus Holm

Results 132 comments of Magnus Holm

> While this is fully something one can do and it's great to see performance here for Imba, it is generally something you wouldn't due in many libraries as it's...

Wow, very interesting concept! I'm definitely open to adding support for this in 2.1.0. My main concern is adding it in an opt-in way. It's a bit tricky now since...

> Have you had a chance to review this? I've been a bit busy so I haven't been able to test out the code locally yet. Hoping to do it...

https://github.com/hanami/hanami/issues/1015 seems to be a separate bug related to class scoping: ``` Boot Error Something went wrong while loading .../project/config.ru NameError: uninitialized constant Hanami::View::Rendering::Scope::String Did you mean? String StringIO STDIN...

I do believe that we actually intentionally said that constant lookup should be based in `Object` even though the scope is based on BasicObject. Doesn't seem to be a test...

Public methods for already-available-template-classes and attempt-to-load-everything-that's-lazy-loadable will come it Tilt 2.1.

@nyarly do you still need this?

What's a sensible API? I was thinking: - Tilt::Mapping#registered_templates `=> { "erb" => Tilt::ErbTemplate, … }` - Tilt::Mapping#load_lazy_templates Not sure about the name of the last one.

I'd accept a pull request for this feature. Otherwise I'll queue it up for later OSS work.