Judah Rand

Results 94 comments of Judah Rand

I can confirm that I am able to connect to the Redis instance from my dev machine using the credentials given to me by Heroku. This is the return on...

Oh and I forgot the commit SHA. I've tried 77d0a2a0fb5ff70d2778406661f03f29e4279359 and 5ae8ec7a32f22a99c1c547a57b2f87d536a419f1

I think I might have solved this. I think it was down to there actually being 2 Redis connection pools defined in the code. One of which default to `poolsize=50`...

I think the issue here is the use of the `get_redis` function in `get_subscriptions`. Though I could be wrong. This means that both connection pools are needed even if `USAGE_REPORTING...

And looking into the commit history a bit more it looks like this subscription checking into Redis should only be happening if `SUBSCRIPTIONS_ENABLED is True`. I'll open a PR for...

Should have labelled with `bug` 😛

Relying on the hash-ability of parameters can be dealt with in the way that Joblib does it - by using `pickle.dumps` to turn the parameter into bytes and then hashing...

>Use both the first and last assignment event for the conversion window (any conversions from 1/1 to 1/10 would be included) How would this work with `Exclude In-Progress Conversions` given...