Joe Sylve

@scudette have you gotten a chance to review this? By default it still builds with c++11 (so no changes for existing users), but gives the option of choosing a different...

That's weird. Since the enum is declared inside of a class, it shouldn't violate the one definition rule. The spec even states ``` A class name (9.1) or enumeration name...

If you change the definition from `enum` to `enum class`, does it fix your compile error? The additional scope is a bit annoying, and I suspect a compiler bug, but...

Interesting. I think it's a gcc bug. Here's a minimal example: https://godbolt.org/z/YdkLxW This can be fixed by specifying the namespace: https://godbolt.org/z/dLm3ct I'm updating the PR to support this. I think...

PR updated. Give it a try

Merge conflicts resolved. @scudette have you gotten a chance to look at this since I fixed the issues?

Given that both types of images exist in the wild, practically readers need to be able to read both, so I agree that it's probably best just to add the...

I could be reading it wrong, but does this patch auto load any and all aff4 images in the same directory as the one the user is specifying? If so,...

This project benefit from the use of a .clang-format file or similar to deal with the formatting issues consistently.

I think this is a good optimization, but I fear it's overly specific and too restrictive to be a requirement. I think the spec could benefit from a section on...